Swoole: Follow symlinks to enable zero-downtime deployment#1009
Closed
mikkpokk wants to merge 9 commits into
Closed
Swoole: Follow symlinks to enable zero-downtime deployment#1009mikkpokk wants to merge 9 commits into
mikkpokk wants to merge 9 commits into
Conversation
Member
|
Hello! Are you able to update this PR to follow Laravel's code style conventions? |
Author
|
@taylorotwell Hello! Done. Added the necessary PHPDoc and verified the code with Laravel Pint using I've no idea why the Roadrunner tests on the cloud are failing randomly. They are not related at all. Most likely caused by #1008 |
osbre
reviewed
Apr 6, 2025
osbre
reviewed
Apr 6, 2025
Contributor
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue is addressed in #1004. This PR fixes the addressed issue.
What does this PR do?
SCRIPT_NAMEcontains the base directory and it differs frombasePath, it replaces realpath paths with symlinked paths.swoole-serverusing the environment parameterAPP_RELEASE_BIN_DIR.swoole-serverusesAPP_RELEASE_BIN_DIRinstead of the PHP realpath__DIR__.swoole-serverlistens to the Swoole eventbeforereload. Whenever the app is reloaded, it clears the PHP directory caches usingclearstatcache(true).